From: Bryan Davis <bd808@wikimedia.org>
Date: Fri, 13 Dec 2013 19:49:45 +0000 (-0700)
Subject: Fix TempFSFile creation
X-Git-Tag: 1.31.0-rc.0~17648
X-Git-Url: http://git.cyclocoop.org/%22.%24match%5B1%5D.%22?a=commitdiff_plain;h=f9c6af781cc5af03e9a6395a701322f67bc6e803;p=lhc%2Fweb%2Fwiklou.git

Fix TempFSFile creation

A new TempFSFile should be instantiated via the factory rather than
using the object constructor.

Change-Id: Icd059566087c6a644a0d0ed69abfe13b88b38ee4
---

diff --git a/includes/upload/UploadFromUrl.php b/includes/upload/UploadFromUrl.php
index 6d956e2aa4..19b4dfde4c 100644
--- a/includes/upload/UploadFromUrl.php
+++ b/includes/upload/UploadFromUrl.php
@@ -211,7 +211,7 @@ class UploadFromUrl extends UploadBase {
 	 * @return string Path to the file
 	 */
 	protected function makeTemporaryFile() {
-		$tmpFile = new TempFSFile( 'URL' );
+		$tmpFile = TempFSFile::factory( 'URL' );
 		$tmpFile->bind( $this );
 		return $tmpFile->getPath();
 	}